Property Editor Dialog: Set height to 100% for `umb-property-editor-ui-picker-modal` by bjarnef · Pull Request #22354 · umbraco/Umbraco-CMS

bjarnef · 2026-04-05T22:49:38Z

Prerequisites

I have added steps to test this contribution in the description below

Description

Changes in #21825 has an impact on how footer aligned in property editor UI modal, which is causes by these lines added to host element:

:host {
    display: block;
    container-type: inline-size;
}

In 17.2.2

With latest changes in main branch, which doesn't align footer at bottom as previous:

Adding height: 100% to host element ensures footer stick to bottom as because in both unfiltered and filtered results.

github-actions · 2026-04-05T22:49:47Z

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
The automated tests all pass (see "Checks" tab on this PR)
The level of security for this contribution is the same or improved
The level of performance for this contribution is the same or improved
Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copilot

Pull request overview

Fixes a regression in the property editor UI picker sidebar modal layout so the footer/actions area aligns to the bottom again (as in 17.2.2), following modal sizing changes introduced in #21825.

Changes:

Set the umb-property-editor-ui-picker-modal host element height to 100% so its internal umb-body-layout can correctly stretch and place the footer/actions at the bottom.

AndyButland

Thanks @bjarnef - I've tested this out and can confirm it fixes the issue such that the footer buttons are consistently aligned at the bottom.

bjarnef · 2026-04-08T11:14:29Z

@AndyButland probably too late for v17.3.1 .. but perhaps include this tiny change for v17.3.2 ?

AndyButland · 2026-04-08T11:28:11Z

If more critical reasons for another patch release come up, we can include this one too. But I don't think we'll do one just for this.

…i-picker-modal` (#22354) Set height to 100% for ui-picker-modal element

Updated [Umbraco.Cms](https://github.com/umbraco/Umbraco-CMS) from 17.3.1 to 17.3.3. <details> <summary>Release notes</summary> _Sourced from [Umbraco.Cms's releases](https://github.com/umbraco/Umbraco-CMS/releases)._ ## 17.3.3 ## What's Changed ### 🐛 Bug Fixes * User Service: Prevent fetching all permissions when no IDs are provided by @krebil in umbraco/Umbraco-CMS#22424 **Full Changelog**: umbraco/Umbraco-CMS@release-17.3.2...release-17.3.3 ## 17.3.2 ## What's Changed ### 🐛 Bug Fixes * Templating: Move production mode validation from service layer to Management API by @AndyButland in umbraco/Umbraco-CMS#22383 * Migrations: Fix potential OptimizeInvariantUrlRecords timeout on SQL Server (closes #22377) by @AndyButland in umbraco/Umbraco-CMS#22382 * Management API: Fix OAuth client registration permanently skipped after transient failure (closes #22356) by @AndyButland in umbraco/Umbraco-CMS#22368 * Property Editor Dialog: Set height to 100% for `umb-property-editor-ui-picker-modal` by @bjarnef in umbraco/Umbraco-CMS#22354 **Full Changelog**: umbraco/Umbraco-CMS@release-17.3.1...release-17.3.2 Commits viewable in [compare view](umbraco/Umbraco-CMS@release-17.3.1...release-17.3.3). </details> Updated [Umbraco.Cms.Persistence.Sqlite](https://github.com/umbraco/Umbraco-CMS) from 17.3.1 to 17.3.3. <details> <summary>Release notes</summary> _Sourced from [Umbraco.Cms.Persistence.Sqlite's releases](https://github.com/umbraco/Umbraco-CMS/releases)._ ## 17.3.3 ## What's Changed ### 🐛 Bug Fixes * User Service: Prevent fetching all permissions when no IDs are provided by @krebil in umbraco/Umbraco-CMS#22424 **Full Changelog**: umbraco/Umbraco-CMS@release-17.3.2...release-17.3.3 ## 17.3.2 ## What's Changed ### 🐛 Bug Fixes * Templating: Move production mode validation from service layer to Management API by @AndyButland in umbraco/Umbraco-CMS#22383 * Migrations: Fix potential OptimizeInvariantUrlRecords timeout on SQL Server (closes #22377) by @AndyButland in umbraco/Umbraco-CMS#22382 * Management API: Fix OAuth client registration permanently skipped after transient failure (closes #22356) by @AndyButland in umbraco/Umbraco-CMS#22368 * Property Editor Dialog: Set height to 100% for `umb-property-editor-ui-picker-modal` by @bjarnef in umbraco/Umbraco-CMS#22354 **Full Changelog**: umbraco/Umbraco-CMS@release-17.3.1...release-17.3.2 Commits viewable in [compare view](umbraco/Umbraco-CMS@release-17.3.1...release-17.3.3). </details> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Set height to 100% for ui-picker-modal element

6eedcd3

Copilot AI review requested due to automatic review settings April 5, 2026 22:49

Copilot started reviewing on behalf of bjarnef April 5, 2026 22:50 View session

Copilot AI reviewed Apr 5, 2026

View reviewed changes

bjarnef changed the title ~~Set height to 100% for ui-picker-modal element~~ Fix: Set height to 100% for umb-property-editor-ui-picker-modal Apr 5, 2026

bjarnef added 3 commits April 7, 2026 08:11

Merge branch 'main' into patch-8

0b4a5e3

Merge branch 'main' into patch-8

14ec385

Merge branch 'main' into patch-8

c736925

AndyButland added community/pr release/17.4.0 labels Apr 8, 2026

AndyButland approved these changes Apr 8, 2026

View reviewed changes

AndyButland changed the title ~~Fix: Set height to 100% for umb-property-editor-ui-picker-modal~~ Property Editor Dialog: Set height to 100% for umb-property-editor-ui-picker-modal Apr 8, 2026

AndyButland merged commit ac54cfd into umbraco:main Apr 8, 2026
29 checks passed

bjarnef deleted the patch-8 branch April 8, 2026 10:04

AndyButland pushed a commit that referenced this pull request Apr 9, 2026

Property Editor Dialog: Set height to 100% for `umb-property-editor-u…

5d6e3df

…i-picker-modal` (#22354) Set height to 100% for ui-picker-modal element

AndyButland added release/17.3.2 and removed release/17.4.0 labels Apr 9, 2026

This was referenced Apr 20, 2026

Bump Umbraco.Cms.Api.Common from 17.0.0 to 17.3.4 umbraco-community/Umbraco.Community.Sustainability#90

Open

Bump Umbraco.Cms.Web.Website from 17.0.0 to 17.3.4 umbraco-community/Umbraco.Community.Sustainability#91

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Property Editor Dialog: Set height to 100% for `umb-property-editor-ui-picker-modal`#22354

Property Editor Dialog: Set height to 100% for `umb-property-editor-ui-picker-modal`#22354
AndyButland merged 4 commits intoumbraco:mainfrom
bjarnef:patch-8

bjarnef commented Apr 5, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

AndyButland left a comment

Uh oh!

Uh oh!

bjarnef commented Apr 8, 2026

Uh oh!

AndyButland commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bjarnef commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Prerequisites

Description

Uh oh!

github-actions Bot commented Apr 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

AndyButland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bjarnef commented Apr 8, 2026

Uh oh!

AndyButland commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bjarnef commented Apr 5, 2026 •

edited

Loading